Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update sizebot node_modules caching strategy #30393

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 18, 2024

Stack from ghstack (oldest at bottom):

The download job for sizebot requires both modules from the root repo
but also has a nested yarn lockfile in scripts/release. Calculate the
hash for the cache using both lockfiles.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 9:40pm

poteto added a commit that referenced this pull request Jul 18, 2024
The download job for sizebot requires both modules from the root repo
but also has a nested yarn lockfile in scripts/release. Calculate the
hash for the cache using both lockfiles.

ghstack-source-id: fc1703b547ab906ee244cfa3540414a6df8c660e
Pull Request resolved: #30393
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 18, 2024
@react-sizebot
Copy link

Comparing: fd2b3e1...49ce690

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.31 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e36cd65

@poteto poteto merged commit e36cd65 into gh/poteto/37/base Jul 18, 2024
190 checks passed
poteto added a commit that referenced this pull request Jul 18, 2024
The download job for sizebot requires both modules from the root repo
but also has a nested yarn lockfile in scripts/release. Calculate the
hash for the cache using both lockfiles.

ghstack-source-id: fc1703b547ab906ee244cfa3540414a6df8c660e
Pull Request resolved: #30393
@poteto poteto deleted the gh/poteto/37/head branch July 18, 2024 21:42
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
The download job for sizebot requires both modules from the root repo
but also has a nested yarn lockfile in scripts/release. Calculate the
hash for the cache using both lockfiles.

ghstack-source-id: fc1703b547ab906ee244cfa3540414a6df8c660e
Pull Request resolved: facebook#30393
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
The download job for sizebot requires both modules from the root repo
but also has a nested yarn lockfile in scripts/release. Calculate the
hash for the cache using both lockfiles.

ghstack-source-id: fc1703b547ab906ee244cfa3540414a6df8c660e
Pull Request resolved: facebook#30393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants