Log Fragment name when trying to render a lazy fragment #30372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 163365a...228669e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
reviewed
Jul 22, 2024
packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js
Outdated
Show resolved
Hide resolved
| @@ -1891,11 +1892,13 @@ function mountLazyComponent( | |||
| } | |||
| } | |||
|
|
|||
| const loggedComponent = Component === REACT_FRAGMENT_TYPE ? '<Fragment>' : Component; | |||
There was a problem hiding this comment.
We can use getComponentNameFromType from shared/getComponentNameFromType here instead. That way we also get a better name for all the other types you're not supposed to use.
Suggested change
| const loggedComponent = Component === REACT_FRAGMENT_TYPE ? '<Fragment>' : Component; | |
| const loggedComponent = getComponentNameFromType(Component) || String(Component); |
There was a problem hiding this comment.
Forgot that we use + '' for perf so || (Component + '') it is.
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
eps1lon
changed the title
|
Prettier and lint failing. |
|
@eps1lon I chose to ignore the string coercion lint, let me know if that's not ok and I can find a different way forward - probably by introducing a new string coercion check function for components? |
|
Let's just be simple about it and do what the lint rule asks. |
|
Seems like common practice though. |
What solution are you thinking of? The lint rule asks to use a "checkXxxxxStringCoercion" function but none exists for components right now, which is why I suggested creating one. |
eps1lon
approved these changes
Jul 23, 2024
Just kept the original behavior. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
DiffTrain build for commit 9cc0f6e.
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26910
How did you test this change?
See test.