Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Component Stack from React Logged Warnings and Error Reporting #30308

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Remove Component Stack from React Logged Warnings and Error Reporting #30308

merged 6 commits into from
Jul 12, 2024

Commits on Jul 11, 2024

  1. Delete component stacks from React printed errors

    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    03b2f7f View commit details
    Browse the repository at this point in the history

  2. Disable tests that assert on default logging behavior 

    This doesn't test for general warnings but for actual error logging so they
use a different mechanism without the polyfill.

We can't really test React.captureOwnerStack() here since this is tracking
default behavior. Could maybe test reading it inside the mock?
    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    923f01f View commit details
    Browse the repository at this point in the history

  3. Update test that used to be missing the stack but is now covered 

    Since third parties would be covered by a polyfill/devtools.
    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    29ead7f View commit details
    Browse the repository at this point in the history

  4. Flight tests need to have the right version of "react" when we log on… 

    … the server
    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2c53738 View commit details
    Browse the repository at this point in the history

  5. Update manual mock in test

    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ee868f6 View commit details
    Browse the repository at this point in the history

  6. Update test of the error messages in the tool itself 

    They now sometimes include a normalized component stack if one was logged.
    @sebmarkbage
    sebmarkbage committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    92b1e9d View commit details
    Browse the repository at this point in the history