-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Examples of invalid code reassigning locals outside of render #30106
Merged
josephsavona
merged 2 commits into
gh/josephsavona/32/base
from
gh/josephsavona/32/head
Jun 26, 2024
Merged
[compiler] Examples of invalid code reassigning locals outside of render #30106
josephsavona
merged 2 commits into
gh/josephsavona/32/base
from
gh/josephsavona/32/head
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
Opened by a member of the React Core Team
label
Jun 26, 2024
Comparing: ef0f44e...59015bc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
…side of render" [ghstack-poisoned]
mvitousek
approved these changes
Jun 26, 2024
josephsavona
added a commit
that referenced
this pull request
Jun 26, 2024
ghstack-source-id: c48d0d0b86e47e2449982263c88cc2cfd44e326b Pull Request resolved: #30106
mvitousek
added a commit
that referenced
this pull request
Jun 26, 2024
Summary: Additional repro demonstrating a case that still exists after #30106 [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Jun 27, 2024
…sue" Summary: Additional repro demonstrating a case that still exists after #30106 [ghstack-poisoned]
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):