Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add yarn_test_build job to gh actions #30072

Merged
merged 33 commits into from
Jul 12, 2024
Merged

Conversation

[ghstack-poisoned]
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 3:11pm

poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: 9cd55d391a57a0254dc07c0982047005a89a2390
Pull Request resolved: #30072
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 24, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 24, 2024

Comparing: e6783e7...cd878f1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against cd878f1

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: 2329f4cb6c03b89e4621fb5141c79695301b6b8e
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: 6df35817371d0d3acf173227d0ac9e377543aa34
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: 642200ae95d8bc9009d08f495f1391950054be8c
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: c1bf83b54925954be64274bac3595acbb68f0d23
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: 8fba65fbc40ca07fc629d39adfb487d37e0b4244
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: a8c594d753f454dd0695a1f8028e0a635fb1bc01
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 24, 2024
ghstack-source-id: a69f045720f4fe61ead4069ffdfb700288d630c9
Pull Request resolved: #30072
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
poteto added a commit to poteto/react that referenced this pull request Jul 10, 2024
ghstack-source-id: 2588f3588f399f332225b353e67efa3816587401
Pull Request resolved: facebook#30072
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 2588f3588f399f332225b353e67efa3816587401
Pull Request resolved: #30072
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd
Pull Request resolved: #30072
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd
Pull Request resolved: #30072
poteto added a commit that referenced this pull request Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd
Pull Request resolved: #30072
poteto added a commit that referenced this pull request Jul 12, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd
Pull Request resolved: #30072
[ghstack-poisoned]
Comment on lines +61 to +90
test_params: [
# Intentionally passing these as strings instead of creating a
# separate parameter per CLI argument, since it's easier to
# control/see which combinations we want to run.
-r=stable --env=development,
-r=stable --env=production,
-r=experimental --env=development,
-r=experimental --env=production,

# Dev Tools
--project=devtools -r=experimental,

# TODO: Update test config to support www build tests
# - "-r=www-classic --env=development --variant=false"
# - "-r=www-classic --env=production --variant=false"
# - "-r=www-classic --env=development --variant=true"
# - "-r=www-classic --env=production --variant=true"
# - "-r=www-modern --env=development --variant=false"
# - "-r=www-modern --env=production --variant=false"
# - "-r=www-modern --env=development --variant=true"
# - "-r=www-modern --env=production --variant=true"

# TODO: Update test config to support xplat build tests
# - "-r=xplat --env=development --variant=false"
# - "-r=xplat --env=development --variant=true"
# - "-r=xplat --env=production --variant=false"
# - "-r=xplat --env=production --variant=true"

# TODO: Test more persistent configurations?
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from circleci config

merge-multiple: true
- name: Display structure of build
run: ls -R build
- run: yarn test --build ${{ matrix.test_params }} --ci=github
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this parallelize by default? If not, should we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is parallelized, it uses the matrix defined above and creates a CI worker for each value in the matrix

@poteto poteto merged commit 0e1e97c into gh/poteto/26/base Jul 12, 2024
187 checks passed
poteto added a commit that referenced this pull request Jul 12, 2024
ghstack-source-id: 5cff9778611acb747c05b9d353bd1af3b11e7d7a
Pull Request resolved: #30072
@poteto poteto deleted the gh/poteto/26/head branch July 12, 2024 16:09
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 5cff9778611acb747c05b9d353bd1af3b11e7d7a
Pull Request resolved: facebook#30072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants