Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumbing of isomorphic code #29967

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

sebmarkbage
Copy link
Collaborator

Need to tighten up this a bit.

react-dom isomorphic currently depends on react-reconciler which is mostly DCE but it's pulled in which makes it hard to make other bundling changes.

ReactFlightServer can have a hard dependency on the module that imports its internals since even if other internals are aliased it still always needs the server one.

@sebmarkbage sebmarkbage requested a review from gnoff June 20, 2024 10:02
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:04am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 20, 2024
@react-sizebot
Copy link

Comparing: 83d538e...f60ac44

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js +0.29% 6.66 kB 6.68 kB +0.27% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js +0.28% 6.67 kB 6.69 kB +0.27% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 597.17 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.52 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-dom/cjs/react-dom.react-server.development.js +0.39% 14.67 kB 14.73 kB +0.17% 3.03 kB 3.03 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +0.39% 14.67 kB 14.73 kB +0.17% 3.03 kB 3.03 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +0.39% 14.69 kB 14.75 kB +0.20% 3.06 kB 3.06 kB
oss-stable-rc/react-dom/cjs/react-dom.production.js +0.29% 6.64 kB 6.66 kB +0.33% 1.80 kB 1.80 kB
oss-stable-semver/react-dom/cjs/react-dom.production.js +0.29% 6.64 kB 6.66 kB +0.33% 1.80 kB 1.80 kB
oss-stable/react-dom/cjs/react-dom.production.js +0.29% 6.66 kB 6.68 kB +0.27% 1.82 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom.production.js +0.28% 6.67 kB 6.69 kB +0.27% 1.83 kB 1.83 kB
oss-stable-rc/react-dom/cjs/react-dom.react-server.production.js +0.21% 4.87 kB 4.88 kB +0.08% 1.26 kB 1.26 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +0.21% 4.87 kB 4.88 kB +0.08% 1.26 kB 1.26 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +0.20% 4.89 kB 4.90 kB = 1.28 kB 1.28 kB
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +0.20% 4.90 kB 4.91 kB = 1.29 kB 1.29 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against f60ac44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants