Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set disableLegacyMode to true for www #29871

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Set disableLegacyMode to true for www #29871

merged 1 commit into from
Jun 14, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 12, 2024

Set disableLegacyMode to true for www

@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:48pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 12, 2024
@react-sizebot
Copy link

Comparing: f3e09d6...fe2491a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.80 kB 497.80 kB = 89.24 kB 89.23 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.62 kB 502.62 kB = 89.94 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 597.04 kB 582.95 kB = 105.31 kB 103.20 kB
facebook-www/ReactDOM-prod.modern.js = 571.38 kB 571.38 kB = 101.25 kB 101.25 kB
facebook-www/ReactART-dev.classic.js = 649.11 kB 635.74 kB = 104.10 kB 102.38 kB
facebook-www/ReactReconciler-dev.classic.js = 730.64 kB 715.56 kB = 116.65 kB 114.39 kB
facebook-www/ReactDOMTesting-prod.classic.js = 611.78 kB 597.69 kB = 109.03 kB 106.88 kB
facebook-www/ReactDOM-profiling.classic.js = 626.80 kB 612.12 kB = 109.74 kB 107.44 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,088.49 kB 1,061.66 kB = 183.92 kB 179.26 kB
facebook-www/ReactDOM-dev.classic.js = 1,071.58 kB 1,044.75 kB = 179.96 kB 175.38 kB
test_utils/ReactAllWarnings.js Deleted 63.50 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/JSXDEVRuntime-dev.classic.js = 32.57 kB 32.44 kB = 7.61 kB 7.59 kB
facebook-www/React-dev.classic.js = 73.68 kB 72.82 kB = 16.14 kB 16.01 kB
facebook-www/ReactReconciler-prod.classic.js = 458.36 kB 449.78 kB = 74.03 kB 72.71 kB
facebook-www/ReactART-prod.classic.js = 367.22 kB 359.94 kB = 62.09 kB 60.95 kB
facebook-www/ReactART-dev.classic.js = 649.11 kB 635.74 kB = 104.10 kB 102.38 kB
facebook-www/ReactReconciler-dev.classic.js = 730.64 kB 715.56 kB = 116.65 kB 114.39 kB
facebook-www/ReactDOMTesting-prod.classic.js = 611.78 kB 597.69 kB = 109.03 kB 106.88 kB
facebook-www/ReactDOM-profiling.classic.js = 626.80 kB 612.12 kB = 109.74 kB 107.44 kB
facebook-www/ReactDOM-prod.classic.js = 597.04 kB 582.95 kB = 105.31 kB 103.20 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,088.49 kB 1,061.66 kB = 183.92 kB 179.26 kB
facebook-www/ReactDOM-dev.classic.js = 1,071.58 kB 1,044.75 kB = 179.96 kB 175.38 kB
test_utils/ReactAllWarnings.js Deleted 63.50 kB 0.00 kB Deleted 15.90 kB 0.00 kB

Generated by 🚫 dangerJS against fe2491a

rickhanlonii
rickhanlonii approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jackpope
jackpope approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kassens kassens merged commit fb9a90f into facebook:main Jun 14, 2024
44 checks passed
@kassens kassens deleted the pr29871 branch June 14, 2024 13:52
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@kassens
Set disableLegacyMode to true for www (#29871)
dc2c2d7 
Set disableLegacyMode to true for www

DiffTrain build for [fb9a90f](fb9a90f)
Helloramon
Helloramon reviewed Jun 14, 2024
View reviewed changes
Copy link

@Helloramon Helloramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

kassens added a commit that referenced this pull request Jun 14, 2024
@kassens
Revert "Set disableLegacyMode to true for www (#29871)"
6ef1e22 
This reverts commit fb9a90f.
@kassens kassens mentioned this pull request Jun 14, 2024
Merged
kassens added a commit that referenced this pull request Jun 14, 2024
@kassens
Revert "Set disableLegacyMode to true for www" (#29901)
88959fd 
Reverts #29871

Just temporarily while we're investigating something.
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@kassens
Revert "Set disableLegacyMode to true for www" (#29901)
aed6d81 
Reverts #29871

Just temporarily while we're investigating something.

DiffTrain build for [88959fd](88959fd)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloramon Helloramon Helloramon left review comments

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@jackpope jackpope jackpope approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kassens @react-sizebot @rickhanlonii @jackpope @Helloramon @facebook-github-bot