Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] HIR-based FlattenScopesWithHooksOrUse #29840

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[compiler] HIR-based FlattenScopesWithHooksOrUse #29840

merged 2 commits into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. [compiler] HIR-based FlattenScopesWithHooksOrUse 

    Per title, implements an HIR-based version of FlattenScopesWithHooksOrUse as part of our push to use HIR everywhere. This is the last pass to migrate before PropagateScopeDeps, which is blocking the fix for `bug.invalid-hoisting-functionexpr`, ie where we can infer incorrect dependencies for function expressions if the dependencies are accessed conditionally.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9f2b2a8 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] HIR-based FlattenScopesWithHooksOrUse" 

    Per title, implements an HIR-based version of FlattenScopesWithHooksOrUse as part of our push to use HIR everywhere. This is the last pass to migrate before PropagateScopeDeps, which is blocking the fix for `bug.invalid-hoisting-functionexpr`, ie where we can infer incorrect dependencies for function expressions if the dependencies are accessed conditionally.

[ghstack-poisoned]
    @josephsavona
    josephsavona committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8c61ad1 View commit details
    Browse the repository at this point in the history