Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: getGlobalDeclaration() takes a NonLocalBinding #29189

Merged
merged 3 commits into from
May 24, 2024

Commits on May 21, 2024

  1. compiler: getGlobalDeclaration() takes a NonLocalBinding

    No-op refactor to make Environment#getGlobalDeclaration() take a NonLocalBinding instead of just a name. The idea is that in subsequent PRs we can use information about the binding to resolve a type more accurately. For example, we can resolve `Array` differently if its an import or local and not the global Array. Similar for resolving local `useState` differently than the one from React.
    
    [ghstack-poisoned]
    josephsavona committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c869c38 View commit details
    Browse the repository at this point in the history
  2. Update on "compiler: getGlobalDeclaration() takes a NonLocalBinding"

    No-op refactor to make Environment#getGlobalDeclaration() take a NonLocalBinding instead of just a name. The idea is that in subsequent PRs we can use information about the binding to resolve a type more accurately. For example, we can resolve `Array` differently if its an import or local and not the global Array. Similar for resolving local `useState` differently than the one from React.
    
    [ghstack-poisoned]
    josephsavona committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0d528a8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Update on "compiler: getGlobalDeclaration() takes a NonLocalBinding"

    No-op refactor to make Environment#getGlobalDeclaration() take a NonLocalBinding instead of just a name. The idea is that in subsequent PRs we can use information about the binding to resolve a type more accurately. For example, we can resolve `Array` differently if its an import or local and not the global Array. Similar for resolving local `useState` differently than the one from React.
    
    [ghstack-poisoned]
    josephsavona committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9fe1391 View commit details
    Browse the repository at this point in the history