refactor[react-devtools]: rewrite context menus #29049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ContextMenuContainer
component, which will add all requiredcontextmenu
event listeners to the anchor-element. This component will also receive a list ofitems
that will be displayed in the shown context menu.ContextMenuContainer
component is also usinguseImperativeHandle
hook to extend the instance of the component, so context menus can be managed imperatively viaref
:contextMenu.current?.hide()
, for example.JSON.stringify
on the value, seepackages/react-devtools-shared/src/backend/utils.js
.Go to definition
option is available and you can inspect the real code and then copy it.JSON.stringify
.How did you test this change?
Works with element props and hooks:
Screen.Recording.2024-05-13.at.14.12.24.mov
Works with timeline profiler:
Screen.Recording.2024-05-13.at.14.16.28.mov
Works with Fusebox:
rdt-fusebox.mov