Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS #28581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
commented
Mar 18, 2024
| @@ -43,7 +43,7 @@ export const enableSuspenseCallback = false; | |||
| export const disableLegacyContext = true; | |||
| export const enableTrustedTypesIntegration = false; | |||
| export const disableTextareaChildren = false; | |||
| export const disableModulePatternComponents = false; | |||
| export const disableModulePatternComponents = __NEXT_MAJOR__; | |||
There was a problem hiding this comment.
Note that __NEXT_MAJOR__ is just false for now in RN OSS defined above. This is just a reminder when we do that upgrade.
|
Comparing: a493901...d3bf58a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
I missed this in facebook#28579, for the next major of RN OSS we should also enable this flag.
rickhanlonii
approved these changes
Mar 23, 2024
|
Already fixed in fabd6d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set disableModulePatternComponents flag to NEXT_MAJOR for RN OSS
I missed this in #28579, for the next major of RN OSS we should also
enable this flag.