Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the flag for renderable context #28437

Closed
wants to merge 1 commit into from
Closed

Clean up the flag for renderable context #28437

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 25, 2024

Removes the flag for #28226, turning it on everywhere.

@gaearon gaearon requested a review from rickhanlonii February 25, 2024 18:41
@gaearon gaearon force-pushed the rm-renderable-ctx-flag branch from 20019d2 to ed30b14 Compare February 25, 2024 20:26
@react-sizebot
Copy link

Comparing: 239d06e...ed30b14

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.86 kB 176.79 kB = 55.13 kB 55.12 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.01 kB 178.93 kB = 55.77 kB 55.77 kB
facebook-www/ReactDOM-prod.classic.js = 594.00 kB 592.43 kB = 104.93 kB 104.71 kB
facebook-www/ReactDOM-prod.modern.js = 577.29 kB 576.21 kB = 101.95 kB 101.79 kB
facebook-www/React-dev.classic.js = 125.62 kB 123.10 kB = 29.91 kB 29.58 kB
facebook-www/React-dev.modern.js = 124.04 kB 121.52 kB = 29.52 kB 29.18 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.28 kB 2.23 kB = 0.85 kB 0.85 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.28 kB 2.23 kB = 0.85 kB 0.85 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.31 kB 2.26 kB = 0.86 kB 0.85 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.24 kB 2.20 kB = 0.78 kB 0.77 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.21 kB 2.16 kB = 0.77 kB 0.76 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.21 kB 2.16 kB = 0.77 kB 0.76 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.64 kB 4.52 kB = 1.14 kB 1.13 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.64 kB 4.52 kB = 1.14 kB 1.13 kB
oss-experimental/react-is/umd/react-is.development.js = 7.23 kB 6.84 kB = 1.94 kB 1.86 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.21 kB 6.82 kB = 1.94 kB 1.85 kB
oss-stable/react-is/umd/react-is.development.js = 7.21 kB 6.82 kB = 1.94 kB 1.85 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.26 kB 6.87 kB = 1.83 kB 1.75 kB
oss-experimental/react-is/cjs/react-is.development.js = 6.66 kB 6.29 kB = 1.85 kB 1.76 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 6.63 kB 6.27 kB = 1.84 kB 1.76 kB
oss-stable/react-is/cjs/react-is.development.js = 6.63 kB 6.27 kB = 1.84 kB 1.76 kB
oss-experimental/react-is/cjs/react-is.production.js = 6.65 kB 6.28 kB = 1.81 kB 1.72 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 6.62 kB 6.25 kB = 1.80 kB 1.72 kB
oss-stable/react-is/cjs/react-is.production.js = 6.62 kB 6.25 kB = 1.80 kB 1.72 kB
facebook-www/ReactIs-prod.classic.js = 5.83 kB 5.14 kB = 1.36 kB 1.26 kB
facebook-www/ReactIs-prod.modern.js = 5.83 kB 5.14 kB = 1.36 kB 1.26 kB
facebook-www/ReactIs-dev.classic.js = 8.30 kB 7.30 kB = 1.97 kB 1.82 kB
facebook-www/ReactIs-dev.modern.js = 8.29 kB 7.30 kB = 1.97 kB 1.82 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react/cjs/react.production.js = 38.32 kB 38.24 kB = 10.70 kB 10.67 kB
oss-stable-semver/react/cjs/react.production.js = 38.29 kB 38.22 kB = 10.67 kB 10.65 kB
oss-experimental/react-server/cjs/react-server.production.js = 168.34 kB 167.95 kB = 38.90 kB 38.81 kB
facebook-www/ReactDOMTesting-prod.modern.js = 593.97 kB 592.59 kB = 106.08 kB 105.88 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 156.06 kB 155.68 kB = 36.73 kB 36.64 kB
oss-stable/react-server/cjs/react-server.production.js = 156.06 kB 155.68 kB = 36.73 kB 36.64 kB
oss-experimental/react-server/cjs/react-server.development.js = 213.20 kB 212.67 kB = 49.34 kB 49.22 kB
facebook-www/ReactDOM-profiling.classic.js = 624.44 kB 622.87 kB = 109.49 kB 109.25 kB
facebook-www/ReactART-dev.classic.js = 1,066.89 kB 1,064.19 kB = 209.75 kB 209.43 kB
facebook-www/ReactART-dev.modern.js = 1,054.68 kB 1,051.99 kB = 207.34 kB 207.02 kB
facebook-www/ReactDOMTesting-prod.classic.js = 608.78 kB 607.21 kB = 108.62 kB 108.38 kB
facebook-www/ReactDOM-prod.classic.js = 594.00 kB 592.43 kB = 104.93 kB 104.71 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 200.97 kB 200.43 kB = 47.12 kB 46.99 kB
oss-stable/react-server/cjs/react-server.development.js = 200.97 kB 200.43 kB = 47.12 kB 46.99 kB
facebook-www/ReactDOMServer-dev.classic.js = 495.23 kB 493.77 kB = 100.66 kB 100.42 kB
facebook-www/ReactDOMServer-dev.modern.js = 492.65 kB 491.20 kB = 100.17 kB 99.95 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 485.42 kB 483.97 kB = 98.55 kB 98.34 kB
facebook-www/ReactART-prod.modern.js = 352.38 kB 351.30 kB = 59.92 kB 59.75 kB
oss-experimental/react/cjs/react.react-server.development.js = 83.26 kB 82.97 kB = 23.34 kB 23.27 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.min.js = 9.60 kB 9.56 kB = 3.27 kB 3.26 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.min.js = 9.60 kB 9.56 kB = 3.27 kB 3.26 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.min.js = 9.60 kB 9.56 kB = 3.27 kB 3.26 kB
oss-stable/react/cjs/react.react-server.development.js = 75.70 kB 75.41 kB = 21.03 kB 20.96 kB
oss-stable-semver/react/cjs/react.react-server.development.js = 75.68 kB 75.39 kB = 21.00 kB 20.93 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 208.22 kB 207.41 kB = 38.43 kB 38.28 kB
facebook-www/ReactDOMServer-prod.classic.js = 205.92 kB 205.08 kB = 37.35 kB 37.20 kB
facebook-www/ReactDOMServer-prod.modern.js = 204.36 kB 203.52 kB = 37.06 kB 36.88 kB
facebook-www/ReactART-prod.classic.js = 363.83 kB 362.26 kB = 61.92 kB 61.69 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js = 28.48 kB 28.34 kB = 7.44 kB 7.41 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js = 28.48 kB 28.34 kB = 7.44 kB 7.41 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js = 28.48 kB 28.34 kB = 7.44 kB 7.41 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 49.12 kB 48.81 kB = 13.05 kB 12.98 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 47.71 kB 47.40 kB = 12.68 kB 12.62 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js = 43.72 kB 43.43 kB = 13.10 kB 13.05 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 43.65 kB 43.36 kB = 13.08 kB 13.02 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 42.42 kB 42.13 kB = 12.72 kB 12.66 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js = 42.05 kB 41.76 kB = 12.45 kB 12.38 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js = 42.05 kB 41.76 kB = 12.45 kB 12.38 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 41.98 kB 41.69 kB = 12.43 kB 12.36 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 41.98 kB 41.69 kB = 12.43 kB 12.36 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 40.75 kB 40.46 kB = 12.07 kB 12.01 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 40.75 kB 40.46 kB = 12.07 kB 12.01 kB
facebook-www/ReactServer-dev.modern.js = 93.76 kB 92.97 kB = 22.23 kB 22.13 kB
oss-experimental/react/umd/react.development.js = 125.18 kB 123.44 kB = 32.32 kB 32.06 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.55 kB = 5.41 kB 5.36 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.55 kB = 5.41 kB 5.36 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 18.81 kB 18.55 kB = 5.41 kB 5.36 kB
oss-stable/react/umd/react.development.js = 121.38 kB 119.63 kB = 31.18 kB 30.92 kB
oss-stable-semver/react/umd/react.development.js = 121.35 kB 119.61 kB = 31.15 kB 30.89 kB
facebook-react-native/react/cjs/React-dev.js = 121.91 kB 120.07 kB = 29.25 kB 28.98 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 50.68 kB 49.89 kB = 13.26 kB 13.15 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 50.68 kB 49.89 kB = 13.26 kB 13.15 kB
oss-experimental/react/cjs/react.development.js = 102.07 kB 100.45 kB = 27.58 kB 27.33 kB
facebook-www/React-profiling.classic.js = 21.01 kB 20.67 kB = 5.23 kB 5.18 kB
facebook-www/React-profiling.modern.js = 20.73 kB 20.39 kB = 5.17 kB 5.12 kB
oss-stable/react/cjs/react.development.js = 98.40 kB 96.78 kB = 26.51 kB 26.24 kB
oss-stable-semver/react/cjs/react.development.js = 98.37 kB 96.76 kB = 26.48 kB 26.21 kB
facebook-www/React-prod.classic.js = 20.58 kB 20.24 kB = 5.15 kB 5.11 kB
facebook-www/React-prod.modern.js = 20.29 kB 19.95 kB = 5.08 kB 5.04 kB
facebook-www/React-dev.classic.js = 125.62 kB 123.10 kB = 29.91 kB 29.58 kB
facebook-www/React-dev.modern.js = 124.04 kB 121.52 kB = 29.52 kB 29.18 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.28 kB 2.23 kB = 0.85 kB 0.85 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.28 kB 2.23 kB = 0.85 kB 0.85 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.31 kB 2.26 kB = 0.86 kB 0.85 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.24 kB 2.20 kB = 0.78 kB 0.77 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.21 kB 2.16 kB = 0.77 kB 0.76 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.21 kB 2.16 kB = 0.77 kB 0.76 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.64 kB 4.52 kB = 1.14 kB 1.13 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.64 kB 4.52 kB = 1.14 kB 1.13 kB
oss-experimental/react-is/umd/react-is.development.js = 7.23 kB 6.84 kB = 1.94 kB 1.86 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.21 kB 6.82 kB = 1.94 kB 1.85 kB
oss-stable/react-is/umd/react-is.development.js = 7.21 kB 6.82 kB = 1.94 kB 1.85 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.26 kB 6.87 kB = 1.83 kB 1.75 kB
oss-experimental/react-is/cjs/react-is.development.js = 6.66 kB 6.29 kB = 1.85 kB 1.76 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 6.63 kB 6.27 kB = 1.84 kB 1.76 kB
oss-stable/react-is/cjs/react-is.development.js = 6.63 kB 6.27 kB = 1.84 kB 1.76 kB
oss-experimental/react-is/cjs/react-is.production.js = 6.65 kB 6.28 kB = 1.81 kB 1.72 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 6.62 kB 6.25 kB = 1.80 kB 1.72 kB
oss-stable/react-is/cjs/react-is.production.js = 6.62 kB 6.25 kB = 1.80 kB 1.72 kB
facebook-www/ReactIs-prod.classic.js = 5.83 kB 5.14 kB = 1.36 kB 1.26 kB
facebook-www/ReactIs-prod.modern.js = 5.83 kB 5.14 kB = 1.36 kB 1.26 kB
facebook-www/ReactIs-dev.classic.js = 8.30 kB 7.30 kB = 1.97 kB 1.82 kB
facebook-www/ReactIs-dev.modern.js = 8.29 kB 7.30 kB = 1.97 kB 1.82 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against ed30b14

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label May 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @react-sizebot @facebook-github-bot