Minor updates to findDOMNode, as per additional po #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,8 +34,8 @@ function findDOMNode(componentOrElement) { | |||
| return ReactMount.getNodeFromInstance(componentOrElement); | |||
| } | |||
| invariant( | |||
| !(componentOrElement.render != null && typeof(componentOrElement.render) === 'function'), | |||
| 'Component contains `render` method but is not mounted in the DOM', | |||
| componentOrElement.render == null || typeof(componentOrElement.render) !== 'function', | |||
There was a problem hiding this comment.
I still like the un-demorganized form better. What do people think?
There was a problem hiding this comment.
I think if most of the times in the source we see invariant(condition), it's better to have it that way without negations. I think demorganized version reads more easily.
There was a problem hiding this comment.
I obviously like the demorganized. Also, this is > 80 chars, can you split at the || to quiet one more lint complaint.
jimfb
force-pushed
the
getDOMNode-becomes-findDOMNode
branch
from
1d59155 to
f507ba3
Compare
jimfb
added a commit
that referenced
this pull request
Jan 5, 2015
Minor updates to findDOMNode, as per additional post-commit CR feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to findDOMNode, as per additional post-commit CR feedback.