Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[react-devtools-extensions]: use globals to eliminate dead code #27516

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Oct 13, 2023

Small change to eliminate dead code in builds for different browsers.

Tested by inspecting production sources.

@hoxyq hoxyq requested review from motiz88 and huntie October 13, 2023 15:12
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 13, 2023
@react-sizebot
Copy link

Comparing: 537228f...928621b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.66 kB 174.66 kB = 54.31 kB 54.31 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 176.61 kB 176.61 kB = 54.94 kB 54.94 kB
facebook-www/ReactDOM-prod.classic.js = 565.49 kB 565.49 kB = 99.52 kB 99.52 kB
facebook-www/ReactDOM-prod.modern.js = 549.21 kB 549.21 kB = 96.60 kB 96.60 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 928621b

Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hoxyq hoxyq merged commit 18a9dd1 into facebook:main Oct 16, 2023
36 checks passed
@hoxyq hoxyq deleted the devtools/use-globals-for-browser-flags branch October 16, 2023 13:54
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 18, 2023
hoxyq added a commit that referenced this pull request Oct 18, 2023
Changes:
* fix[devtools/useMemoCache]: add stub for useMemoCache in
ReactDebugHook ([hoxyq](https://github.com/hoxyq) in
[#27472](#27472))
* useDeferredValue should skip initialValue if it suspends
([acdlite](https://github.com/acdlite) in
[#27509](#27509))
* feat[react-devtools-extensions/logging]: initialize session id on the
client for logging ([hoxyq](https://github.com/hoxyq) in
[#27517](#27517))
* refactor[react-devtools-extensions]: use globals to eliminate dead
code ([hoxyq](https://github.com/hoxyq) in
[#27516](#27516))
* fix[devtools/inspectElement]: dont pause initial inspectElement call
when user switches tabs ([hoxyq](https://github.com/hoxyq) in
[#27488](#27488))
@joshuagornall
Copy link

@huntie you can also close this pull request #26984. My suggested changes to @hoxyq were implemented by himself separately in this pull request which covers my previous pull request.

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…de (facebook#27516)

Small change to eliminate dead code in builds for different browsers.

Tested by inspecting production sources.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Changes:
* fix[devtools/useMemoCache]: add stub for useMemoCache in
ReactDebugHook ([hoxyq](https://github.com/hoxyq) in
[facebook#27472](facebook#27472))
* useDeferredValue should skip initialValue if it suspends
([acdlite](https://github.com/acdlite) in
[facebook#27509](facebook#27509))
* feat[react-devtools-extensions/logging]: initialize session id on the
client for logging ([hoxyq](https://github.com/hoxyq) in
[facebook#27517](facebook#27517))
* refactor[react-devtools-extensions]: use globals to eliminate dead
code ([hoxyq](https://github.com/hoxyq) in
[facebook#27516](facebook#27516))
* fix[devtools/inspectElement]: dont pause initial inspectElement call
when user switches tabs ([hoxyq](https://github.com/hoxyq) in
[facebook#27488](facebook#27488))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…de (#27516)

Small change to eliminate dead code in builds for different browsers.

Tested by inspecting production sources.

DiffTrain build for commit 18a9dd1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants