Add React Native test configs #27489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
rn-test-configs
branch
from
a1015cb to
7322b2d
Compare
Adds new Jest configs for running our test suite using React Native feature flags. This includes a special config for the version of RN that Meta uses for internal dogfooding, similar to the equivalent ones used for Meta's web codebase. Practically speaking, the main benefit is we can run our tests in CI with the experimental flags used at Meta without having to enable them in the open source builds. Usage: yarn test -r=native-oss yarn test -r=native-fb yarn test -r=native-fb --no-variant
acdlite
force-pushed
the
rn-test-configs
branch
from
7322b2d to
3ba58db
Compare
|
Comparing: dddfe68...3ba58db Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Some of the tests are failing but I believe they are legit failures exposed by the additional test coverage, I'll look into them |
javache
reviewed
Oct 9, 2023
| // | ||
| // TODO: __VARIANT__ isn't supported for React Native flags yet. You can set the | ||
| // flag here but it won't be set to `true` in any of our test runs. Need to | ||
| // update the test configuration. | ||
|
|
There was a problem hiding this comment.
How does the import here not just a circular dependency? The ReactNativeInternalFeatureFlags import should suffice, since that's defined in flow/xplat.js
|
I landed basically the same thing here as #29734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new Jest configs for running our test suite using React Native feature flags. This includes a special config for the version of RN that Meta uses for internal dogfooding, similar to the equivalent ones used for Meta's web codebase.
Practically speaking, the main benefit is we can run our tests in CI with the experimental flags used at Meta without having to enable them in the open source builds.
Usage: