Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Split ResponseState/Resources into RenderState/ResumableState #27268

Merged
merged 6 commits into from
Aug 22, 2023
Merged

[Fizz] Split ResponseState/Resources into RenderState/ResumableState #27268

merged 6 commits into from
Aug 22, 2023

Commits on Aug 22, 2023

  1. Add postponed result to store resumable state

    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f90fba7 View commit details
    Browse the repository at this point in the history

  2. NodeStreams -> NodeStream 

    This was plural because in the future the result can contain multiple
streams but since it's mostly just one primary one it seems more confusion
that it's not similar to the other API.
    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ffcd249 View commit details
    Browse the repository at this point in the history

  3. Add resume API

    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    504e951 View commit details
    Browse the repository at this point in the history

  4. Split ResponseState/Resources into RenderState/ResumableState

    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e627723 View commit details
    Browse the repository at this point in the history

  5. Expose resume() API but not in stable 

    Since we don't have a top level module for these we have to introduce one
that we can fork.
    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c5abf7a View commit details
    Browse the repository at this point in the history

  6. Reunify createRequest 

    We can split these at the startWork layer instead.
    @sebmarkbage
    sebmarkbage committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    92d4029 View commit details
    Browse the repository at this point in the history