Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suspense replaying forward refs #26535

Merged
merged 10 commits into from
Apr 2, 2023
Merged

Fix suspense replaying forward refs #26535

merged 10 commits into from
Apr 2, 2023

Commits on Apr 2, 2023

  1. Fix suspense replaying forwardRefs (facebook#26385)

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    9829d02 View commit details
    Browse the repository at this point in the history

  2. Add test for use hook with forwardRef

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d561e02 View commit details
    Browse the repository at this point in the history

  3. Add test for forwardRefs second arg with use

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    ede13bc View commit details
    Browse the repository at this point in the history

  4. Fix suspense replaying forwardRefs with correct secondArg

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    5f0fbbf View commit details
    Browse the repository at this point in the history

  5. Improve suspense replaying forwardRef test

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    58dd0f4 View commit details
    Browse the repository at this point in the history

  6. Add replayForwardRef

    @hansottowirtz
    hansottowirtz committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    4aad797 View commit details
    Browse the repository at this point in the history

  7. Poke CircleCI

    @eps1lon
    eps1lon committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    82ab9e0 View commit details
    Browse the repository at this point in the history

  8. Unified replay impl for function component types 

    The only difference between a component wrapped in forwardRef and
one that's not is that the former is passed a ref prop. To make it less
likely that the behavior diverges, I unified replayFunctionComponent
and replayForwardRefComponent into a single function again.

We should do this for the regular begin phase functions, too: instead
of completely forked path for regular functions and forwardRef, they
should both converge into the same path. We already do this for
SimpleMemoComponent.

I also added more test coverage for the different component types
because I noticed we were missing some. Also noticed that legacy
context wasn't being handled during the replay of a function component
wrapped with `memo` and added a test for that.
    @acdlite
    acdlite committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    87a01ab View commit details
    Browse the repository at this point in the history

  9. Unify FunctionComponent and SimpleMemoComponent cases 

    These are the same thing.
    @acdlite
    acdlite committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    f32ae1d View commit details
    Browse the repository at this point in the history

  10. Add back accidentally removed comment 

    Oops
    @acdlite
    acdlite committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    7875d3d View commit details
    Browse the repository at this point in the history