Give context aware message if markup reuse fails #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } else { | ||
| rootElement.removeAttribute(ReactMarkupChecksum.CHECKSUM_ATTR_NAME); | ||
| var rootMarkup = rootElement.outerHTML; | ||
| var diffIndex = longestCommonSubstring(markup, rootMarkup); |
There was a problem hiding this comment.
This is going to blow up. n^2 storage where n is the length of the html. Going to be huge very quickly and you don't really need it. Can you just find the first character that differs instead and display [-20;+20] range from there?
There was a problem hiding this comment.
Fixed in 816b011.
arnihermann
force-pushed
the
diff-msg-on-checksum-fail
branch
from
626e51f to
816b011
Compare
| * | ||
| * @return {int} the index of the character where the strings diverge | ||
| */ | ||
| function longestCommonSubstring(string1, string2) { |
There was a problem hiding this comment.
The name doesn't reflect what it does anymore
The context is an extra message with comparison of where server and client markup started to differ.
arnihermann
force-pushed
the
diff-msg-on-checksum-fail
branch
from
bc494a5 to
a352b94
Compare
vjeux
added a commit
that referenced
this pull request
Dec 1, 2014
Give context aware message if markup reuse fails
This was referenced Apr 29, 2020
This was referenced Jul 28, 2020
This was referenced May 5, 2021
This was referenced Jan 16, 2022
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If markup reuse fails, give context for the failure by showing where output from both server and client side markup start to differ: