Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preconnect and prefetchDNS to rendering-stub #26265

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

huozhi
Copy link
Contributor

@huozhi huozhi commented Feb 28, 2023

Summary

Adding preconnect and prefetchDNS to rendering-stub build

How did you test this change?

@huozhi huozhi marked this pull request as draft February 28, 2023 21:46
@react-sizebot
Copy link

react-sizebot commented Feb 28, 2023

Comparing: b2ae9dd...2a26dfb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 155.25 kB 155.25 kB = 48.98 kB 48.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 157.24 kB 157.24 kB = 49.64 kB 49.64 kB
facebook-www/ReactDOM-prod.classic.js = 532.50 kB 532.50 kB = 94.85 kB 94.85 kB
facebook-www/ReactDOM-prod.modern.js = 516.42 kB 516.42 kB = 92.45 kB 92.45 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +43.19% 2.04 kB 2.92 kB +6.22% 0.87 kB 0.92 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +42.69% 2.07 kB 2.95 kB +6.29% 0.89 kB 0.95 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +42.53% 2.07 kB 2.96 kB +6.26% 0.90 kB 0.95 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +38.51% 2.38 kB 3.30 kB +5.54% 0.98 kB 1.03 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +38.12% 2.41 kB 3.33 kB +5.82% 1.00 kB 1.06 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +38.00% 2.42 kB 3.33 kB +5.69% 1.00 kB 1.06 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.69% 1.04 kB 1.23 kB +3.99% 0.63 kB 0.65 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.27% 1.06 kB 1.26 kB +4.01% 0.65 kB 0.68 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.13% 1.07 kB 1.26 kB +3.83% 0.65 kB 0.68 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.36% 1.27 kB 1.46 kB +3.60% 0.75 kB 0.78 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.10% 1.30 kB 1.48 kB +3.63% 0.77 kB 0.80 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.01% 1.31 kB 1.49 kB +3.35% 0.78 kB 0.80 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +43.19% 2.04 kB 2.92 kB +6.22% 0.87 kB 0.92 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +42.69% 2.07 kB 2.95 kB +6.29% 0.89 kB 0.95 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +42.53% 2.07 kB 2.96 kB +6.26% 0.90 kB 0.95 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +38.51% 2.38 kB 3.30 kB +5.54% 0.98 kB 1.03 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +38.12% 2.41 kB 3.33 kB +5.82% 1.00 kB 1.06 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +38.00% 2.42 kB 3.33 kB +5.69% 1.00 kB 1.06 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.69% 1.04 kB 1.23 kB +3.99% 0.63 kB 0.65 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.27% 1.06 kB 1.26 kB +4.01% 0.65 kB 0.68 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +18.13% 1.07 kB 1.26 kB +3.83% 0.65 kB 0.68 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.36% 1.27 kB 1.46 kB +3.60% 0.75 kB 0.78 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.10% 1.30 kB 1.48 kB +3.63% 0.77 kB 0.80 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.01% 1.31 kB 1.49 kB +3.35% 0.78 kB 0.80 kB

Generated by 🚫 dangerJS against 2a26dfb

@huozhi huozhi marked this pull request as ready for review February 28, 2023 21:53
@sebmarkbage sebmarkbage merged commit 38509cc into facebook:main Feb 28, 2023
github-actions bot pushed a commit that referenced this pull request Feb 28, 2023
<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`,
open `chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

Adding `preconnect` and `prefetchDNS` to rendering-stub build

<!--
Explain the **motivation** for making this change. What existing problem
does the pull request solve?
-->

## How did you test this change?

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->

DiffTrain build for [38509cc](38509cc)
@huozhi huozhi deleted the build/add-api-to-rendering-stub branch February 28, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants