Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: devtools cannot be closed correctly #25510

Merged
merged 10 commits into from
Jun 13, 2023
Merged

fix: devtools cannot be closed correctly #25510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
204379a
fix: devtools cannot be closed correctly
Jack-Works Oct 19, 2022
6d0546d
Merge branch 'main' into codespace-6163
Jack-Works Nov 21, 2022
f8beea2
fix: test
Jack-Works Nov 21, 2022
2bbc8d3
fix: test
Jack-Works Nov 21, 2022
52dacd9
Merge branch 'main' into codespace-6163
Jack-Works Dec 3, 2022
c8100a9
Merge branch 'main' into codespace-6163
Jack-Works Apr 13, 2023
37d6932
Merge branch 'main' into codespace-6163
Jack-Works May 26, 2023
07f1e9b
Merge branch 'main' into codespace-6163
Jack-Works Jun 10, 2023
76020b7
fix: review
Jack-Works Jun 12, 2023
f3c24ef
Merge branch 'main' into codespace-6163
Jack-Works Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-devtools-shared/src/__tests__/bridge-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ describe('Bridge', () => {
send: jest.fn(),
};
const bridge = new Bridge(wall);
const shutdownCallback = jest.fn();
bridge.addListener('shutdown', shutdownCallback);

// Check that we're wired up correctly.
bridge.send('reloadAppForProfiling');
Expand All @@ -36,6 +38,7 @@ describe('Bridge', () => {
expect(wall.send).toHaveBeenCalledWith('update', '1');
expect(wall.send).toHaveBeenCalledWith('update', '2');
expect(wall.send).toHaveBeenCalledWith('shutdown');
expect(shutdownCallback).toHaveBeenCalledTimes(1);

// Verify that the Bridge doesn't send messages after shutdown.
jest.spyOn(console, 'warn').mockImplementation(() => {});
Expand Down
1 change: 1 addition & 0 deletions packages/react-devtools-shared/src/bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ class Bridge<
}

// Queue the shutdown outgoing message for subscribers.
this.emit('shutdown');
this.send('shutdown');

// Mark this bridge as destroyed, i.e. disable its public API.
Expand Down