Move more stuff out of ReactComponent #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of moving more logic out of the base classes. setProps, replaceProps etc. are not accessible from anything other than ReactClass so we can safely move it to ReactCompositeComponent. mountComponentIntoNode is tightly coupled to ReactMount. It's part of the outer abstraction, the mount point, not the individual component.
Since setProps can no longer be called on anything but composites, we can move this complexity into ReactCompositeComponent.
Use preventExtensions so that we can't add expando properties to internal instances. This ensures that the hidden class is kept more consistent.
sebmarkbage
force-pushed
the
cleanupinternals
branch
from
2b1753a to
8ed905b
Compare
sebmarkbage
force-pushed
the
cleanupinternals
branch
from
8ed905b to
6dddd60
Compare
|
Nice. (nit: fold the unused-variables commit into the first commit, which removed the references?) |
|
I didn't know which and if it was several commits I removed them in. I wish I had better lint as I go. |
sebmarkbage
added a commit
that referenced
this pull request
Nov 17, 2014
Move more stuff out of ReactComponent
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a bunch of stuff that doesn't belong in ReactComponent anymore. See individual commits.
I also added a preventExtensions for internals in
__DEV__. This ensures that we don't add state that we don't know about and ensures that the components keep a stable type signature.