Note the need for an Object.assign polyfill #2490
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -68,4 +68,5 @@ Merging two objects can be expressed as: | |||
|
|
|||
| > Note: | |||
| > | |||
| > Use the [JSX command-line tool](http://npmjs.org/package/react-tools) with the `--harmony` flag to activate the experimental ES7 syntax. | |||
| > Use the [JSX command-line tool](http://npmjs.org/package/react-tools) with the `--harmony` flag to activate the experimental ES7 syntax. You may also need to [polyfill](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill) `Object.assign` | |||
There was a problem hiding this comment.
How about:
This experimental syntax compiles into an ES6
Object.assigncall not yet supported by most browsers, so you will likely need to include [a polyfill] if you want to use it.
Thanks for sending in this PR!
There was a problem hiding this comment.
The second "experimental" felt, to me, a bit repetitive, so I left it out, but i can add it back if it feels unclear still. On a whole that wording is much better than my stab at it.
|
We're actually just going to get rid of this mention in the docs entirely in #2636. Thanks for the effort though! We appreciate you taking the time. |
Not sure if this is enough to just place it in the note. Or whether the MDN polyfill link is appropriate, I wanted to provide a solution along with the warning. Another option is pointing them to the react polyfil in the source...
refrences #2488