Basic shallow rendering support (WIP) #2459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP to fix #2393. Doesn't yet support refs or updating.
| ); | ||
| }, | ||
|
|
||
| _arePropsEquivalent: function(props1, props2) { |
There was a problem hiding this comment.
First condition in this case will be totaly ignored. May use every and condition after them?
|
Closing as there will be a v2 on top of the changes to separate ReactClass / ReactCompositeComponent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to fix #2393. Doesn't yet support refs or updating. How's this for a first step?