Trailing commas break old IE versions #2452
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Done! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It'd be nice if this can be shipped. :) Our builds (which check for trailing commas) are failing |
|
Yea we can do this. For our pre-built files we run them through es3ify, which strips trailing commas and quotes reserved words. We don't run this for the npm package though (apart from We may end up going in the other direction and sync out a transform that strips trailing commas as part of the earlier build step. At FB we've actually moved in the opposite direction and don't discourage trailing commas (they do help maintain blame and it's standard procedure in our PHP code). |
Trailing commas break old IE versions
|
Thanks for the explanation! (and the merge!) |
|
If we do a 0.12.1, we'll ship this with it. |
|
Looks like this didn't get shipped in 0.12.1. Can we get it into the next minor release? |
Trailing commas break old IE versions
Sadly, it doesn't look like there is an option (without side-effects) to check that with jshint 👎
(see jshint/jshint#136)