Don't clean up twice in hidden trees #24282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Apr 5, 2022
| @@ -2153,8 +2228,9 @@ function commitMutationEffects_begin(root: FiberRoot, lanes: Lanes) { | |||
| if (deletions !== null) { | |||
| for (let i = 0; i < deletions.length; i++) { | |||
| const childToDelete = deletions[i]; | |||
| const outermostHiddenFiber = findOutermostHiddenFiber(childToDelete); | |||
There was a problem hiding this comment.
This searches up to the root for each fiber in the deletion list. I don't know if there's a way to avoid this. We need to somehow know where we are in the tree before we start descending.
gaearon
commented
Apr 5, 2022
| @@ -1980,7 +1980,6 @@ describe('ReactSuspenseEffectsSemantics', () => { | |||
|
|
|||
| // Destroy layout and passive effects in the errored tree. | |||
| 'App destroy layout', | |||
| 'ThrowsInWillUnmount componentWillUnmount', | |||
There was a problem hiding this comment.
I think this was a bug since it was already earlier in the list. So removing it seems correct to me.
|
Comparing: af73043...01e3269 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Fixed in #24308 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #24281
Fixes #24280. This is pretty invasive and likely subtly (or not so subtly) wrong.
Putting it out there for discussion on the approach.
Without whitespace
The idea is to track the "outermost hidden" Offscreen node during the commit traversal. We need to know the outermost one because it's the one that determines whether we're actually hidden or not. We need the fiber and not just the boolean because we need to know when on our way up to reset the state.