Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Selective Hydration / Event Replay flag #24156

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

salazarm
Copy link
Contributor

Summary

The flag has been on for a while internally and in OSS. This PR removes all of the old unused logic.

How did you test this change?

jest

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 24, 2022
@sizebot
Copy link

sizebot commented Mar 24, 2022

Comparing: 645ec5d...49a9661

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.96 kB 130.91 kB = 41.93 kB 41.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.02 kB 135.98 kB = 43.41 kB 43.39 kB
facebook-www/ReactDOM-prod.classic.js = 435.63 kB 430.43 kB = 79.79 kB 79.36 kB
facebook-www/ReactDOM-prod.modern.js = 422.05 kB 416.59 kB = 77.78 kB 77.16 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.63 kB 430.43 kB = 79.80 kB 79.36 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactFlightDOMRelayServer-dev.modern.js = 53.40 kB 53.24 kB = 13.56 kB 13.52 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js = 53.34 kB 53.19 kB = 13.54 kB 13.51 kB
facebook-www/ReactTestUtils-dev.classic.js = 49.58 kB 49.43 kB = 13.85 kB 13.81 kB
facebook-www/ReactTestUtils-dev.modern.js = 49.58 kB 49.42 kB = 13.85 kB 13.82 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 45.40 kB 45.25 kB = 12.86 kB 12.82 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 45.40 kB 45.25 kB = 12.86 kB 12.82 kB
facebook-www/ReactDOM-dev.classic.js = 1,139.08 kB 1,131.68 kB = 251.45 kB 250.51 kB
facebook-www/ReactDOMForked-dev.classic.js = 1,139.08 kB 1,131.68 kB = 251.45 kB 250.51 kB
facebook-www/ReactDOM-dev.modern.js = 1,116.05 kB 1,108.18 kB = 247.22 kB 246.01 kB
facebook-www/ReactDOMForked-dev.modern.js = 1,116.05 kB 1,108.18 kB = 247.22 kB 246.01 kB
facebook-www/ReactDOM-profiling.classic.js = 466.34 kB 461.18 kB = 84.42 kB 83.98 kB
facebook-www/ReactDOMForked-profiling.classic.js = 466.34 kB 461.18 kB = 84.43 kB 83.98 kB
facebook-www/ReactDOM-prod.classic.js = 435.63 kB 430.43 kB = 79.79 kB 79.36 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.63 kB 430.43 kB = 79.80 kB 79.36 kB
facebook-www/ReactDOM-profiling.modern.js = 452.70 kB 447.24 kB = 82.32 kB 81.69 kB
facebook-www/ReactDOMForked-profiling.modern.js = 452.70 kB 447.24 kB = 82.33 kB 81.70 kB
facebook-www/ReactDOM-prod.modern.js = 422.05 kB 416.59 kB = 77.78 kB 77.16 kB
facebook-www/ReactDOMForked-prod.modern.js = 422.05 kB 416.59 kB = 77.78 kB 77.17 kB
facebook-www/ReactIs-dev.classic.js = 9.68 kB 9.52 kB = 2.56 kB 2.53 kB
facebook-www/ReactIs-dev.modern.js = 9.68 kB 9.52 kB = 2.56 kB 2.53 kB

Generated by 🚫 dangerJS against 49a9661

@salazarm salazarm merged commit 6b85823 into facebook:main Mar 24, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 12, 2022
Summary:
I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS.

This sync includes the following changes:
- **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>//
- **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([#24166](facebook/react#24166)) //<salazarm>//
- **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156)) //<salazarm>//

Changelog:
[General][Changed] - React Native sync for revisions 1159ff6...34aa5cf

jest_e2e[run_all_tests]

Reviewed By: cortinico

Differential Revision: D35504622

fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167
rickhanlonii pushed a commit that referenced this pull request Apr 13, 2022
* clean up selective hydration / replay flag

* dont export return_targetInst
rickhanlonii added a commit that referenced this pull request Apr 14, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* clean up selective hydration / replay flag

* dont export return_targetInst
rickhanlonii added a commit to rickhanlonii/react that referenced this pull request Apr 19, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 26, 2022
Summary:
This sync includes the following changes:
- **[bd4784c8f](facebook/react@bd4784c8f )**: Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) ([#24434](facebook/react#24434)) //<dan>//
- **[6d3b6d0f4](facebook/react@6d3b6d0f4 )**: forwardRef et al shouldn't affect if props reused ([#24421](facebook/react#24421)) //<Andrew Clark>//
- **[bd0813766](facebook/react@bd0813766 )**: Fix: useDeferredValue should reuse previous value ([#24413](facebook/react#24413)) //<Andrew Clark>//
- **[9ae80d6a2](facebook/react@9ae80d6a2 )**: Suppress hydration warnings when a preceding sibling suspends ([#24404](facebook/react#24404)) //<Josh Story>//
- **[0dc4e6663](facebook/react@0dc4e6663 )**: Land enableClientRenderFallbackOnHydrationMismatch ([#24410](facebook/react#24410)) //<Andrew Clark>//
- **[354772952](facebook/react@354772952 )**: Land enableSelectiveHydration flag ([#24406](facebook/react#24406)) //<Andrew Clark>//
- **[392808a1f](facebook/react@392808a1f )**: Land enableClientRenderFallbackOnTextMismatch flag ([#24405](facebook/react#24405)) //<Andrew Clark>//
- **[1e748b452](facebook/react@1e748b452 )**: Land enableLazyElements flag ([#24407](facebook/react#24407)) //<Andrew Clark>//
- **[4175f0593](facebook/react@4175f0593 )**: Temporarily feature flag numeric fallback for symbols ([#24401](facebook/react#24401)) //<Ricky>//
- **[a6d53f346](facebook/react@a6d53f346 )**: Revert "Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156))" ([#24402](facebook/react#24402)) //<Ricky>//
- **[ab9cdd34f](facebook/react@ab9cdd34f )**: Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted ([#24400](facebook/react#24400)) //<Andrew Clark>//
- **[168da8d55](facebook/react@168da8d55 )**: Fix typo that happened during rebasing //<Andrew Clark>//
- **[8bc527a4c](facebook/react@8bc527a4c )**: Bugfix: Fix race condition between interleaved and non-interleaved updates ([#24353](facebook/react#24353)) //<Andrew Clark>//
- **[f7cf077cc](facebook/react@f7cf077cc )**: [Transition Tracing] Add Offscreen Queue ([#24341](facebook/react#24341)) //<Luna Ruan>//
- **[4fc394bbe](facebook/react@4fc394bbe )**: Fix suspense fallback throttling ([#24253](facebook/react#24253)) //<sunderls>//
- **[80170a068](facebook/react@80170a068 )**: Match bundle.name and match upper case entry points ([#24346](facebook/react#24346)) //<Sebastian Markbåge>//
- **[fea6f8da6](facebook/react@fea6f8da6 )**: [Transition Tracing] Add transition to OffscreenState and pendingSuspenseBoundaries to RootState ([#24340](facebook/react#24340)) //<Luna Ruan>//
- **[8e2f9b086](facebook/react@8e2f9b086 )**: move passive flag ([#24339](facebook/react#24339)) //<Luna Ruan>//
- **[55a21ef7e](facebook/react@55a21ef7e )**: fix pushTransition for transition tracing ([#24338](facebook/react#24338)) //<Luna Ruan>//
- **[069d23bb7](facebook/react@069d23bb7 )**:  [eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars ([#24343](facebook/react#24343)) //<Afzal Sayed>//
- **[4997515b9](facebook/react@4997515b9 )**: Point useSubscription to useSyncExternalStore shim ([#24289](facebook/react#24289)) //<dan>//
- **[01e2bff1d](facebook/react@01e2bff1d )**: Remove unnecessary check ([#24332](facebook/react#24332)) //<zhoulixiang>//
- **[d9a0f9e20](facebook/react@d9a0f9e20 )**: Delete create-subscription folder ([#24288](facebook/react#24288)) //<dan>//
- **[f993ffc51](facebook/react@f993ffc51 )**: Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue ([#24247](facebook/react#24247)) //<Andrew Clark>//
- **[fa5800226](facebook/react@fa5800226 )**: [Fizz] Pipeable Stream Perf ([#24291](facebook/react#24291)) //<Josh Story>//
- **[0568c0f8c](facebook/react@0568c0f8c )**: Replace zero with NoLanes for consistency in FiberLane ([#24327](facebook/react#24327)) //<Leo>//
- **[e0160d50c](facebook/react@e0160d50c )**: add transition tracing transitions stack ([#24321](facebook/react#24321)) //<Luna Ruan>//
- **[b0f13e5d3](facebook/react@b0f13e5d3 )**: add pendingPassiveTransitions ([#24320](facebook/react#24320)) //<Luna Ruan>//

Changelog:
[General][Changed] - React Native sync for revisions 60e63b9...bd4784c

jest_e2e[run_all_tests]

Reviewed By: kacieb

Differential Revision: D35899012

fbshipit-source-id: 86a885e336fca9f0efa80cd2b8ca040f2cb53853
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS.

This sync includes the following changes:
- **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>//
- **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([facebook#24166](facebook/react#24166)) //<salazarm>//
- **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([facebook#24156](facebook/react#24156)) //<salazarm>//

Changelog:
[General][Changed] - React Native sync for revisions 1159ff6...34aa5cf

jest_e2e[run_all_tests]

Reviewed By: cortinico

Differential Revision: D35504622

fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants