Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect port of standard Python server #236

Closed
wants to merge 1 commit into from
Closed

Fix incorrect port of standard Python server #236

wants to merge 1 commit into from

Conversation

gasi
Copy link
Contributor

@gasi gasi commented Jul 28, 2013

  • Python’s built-in server listens on port 8000, not 8080.

@zpao
Copy link
Member

zpao commented Jul 29, 2013

Good catch! 2 things:

  1. Can you sign the CLA (https://developers.facebook.com/opensource/cla)?
  2. Can you also update the other place we reference 8080 (the basic-jsx-external example)

@gasi gasi mentioned this pull request Jul 29, 2013
Merged
@gasi
Copy link
Contributor Author

gasi commented Jul 29, 2013

@zpao Thanks. Opened a new pull request: #241.

@gasi gasi closed this Jul 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gasi @zpao