react-core npm module
#232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan wanted an easy way to use React, and specifically behave nicely with browserify. He has been using https://github.com/jordwalke/npm-react-core as a placeholder, but in order to keep doing that, it requires another build step and more places for us to screw up. This just re-uses the NPM module we're already shipping and is really easy to update. Note: we may want to pull this out into it's own project eventually, but for now... move fast?
|
@jordwalke I made https://github.com/facebook/react/wiki/Release-Process when we launched, though it needs a little bit of tweaking (and would need more if we do this) |
Closed
|
Going to close this out. I liked the other route better anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jordan wanted an easy way to use React, and specifically behave nicely
with browserify. He has been using
https://github.com/jordwalke/npm-react-core as a placeholder, but in
order to keep doing that, it requires another build step and more places
for us to screw up. This just re-uses the NPM module we're already
shipping and is really easy to update.
Note: we may want to pull this out into it's own project eventually, but
for now... move fast?