[DevTools] Commands for internal builds all follow :fb convention #22463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaruan
approved these changes
Sep 29, 2021
| @@ -6,12 +6,12 @@ | |||
| "build": "cross-env NODE_ENV=production yarn run build:chrome && yarn run build:firefox && yarn run build:edge", | |||
| "build:dev": "cross-env NODE_ENV=development yarn run build:chrome:dev && yarn run build:firefox:dev && yarn run build:edge:dev", | |||
| "build:chrome": "cross-env NODE_ENV=production node ./chrome/build", | |||
| "build:chrome:crx": "cross-env NODE_ENV=production FEATURE_FLAG_TARGET=extension-fb node ./chrome/build --crx", | |||
| "build:chrome:fb": "cross-env NODE_ENV=production FEATURE_FLAG_TARGET=extension-fb node ./chrome/build --crx", | |||
| "build:chrome:dev": "cross-env NODE_ENV=development node ./chrome/build", | |||
| "build:firefox": "cross-env NODE_ENV=production node ./firefox/build", | |||
| "build:firefox:dev": "cross-env NODE_ENV=development node ./firefox/build", | |||
There was a problem hiding this comment.
Should we have one for Firefox too?
There was a problem hiding this comment.
idk why we don't have one already, but figured i'd just leave as is
There was a problem hiding this comment.
We should maybe add a task to add one @bvaughn
There was a problem hiding this comment.
I don't think Chef auto-installs Firefox add-ons at Facebook, so this build wouldn't be used for anything. (Although TBH the same could be said about Edge extensions. Maybe we should remove that target to reduce confusion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The naming for our internal build commands for
react-devtools-corefollow the:fbconvention, which I believe is more readable, so updating the command for the extensions as well.This PR is paired with an internal diff to update the command name internally.
Test Plan