Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz/Flight] Pass in Destination lazily to startFlowing instead of in createRequest #22449

Merged
merged 4 commits into from
Sep 28, 2021
Merged

[Fizz/Flight] Pass in Destination lazily to startFlowing instead of in createRequest #22449

merged 4 commits into from
Sep 28, 2021

Commits on Sep 28, 2021

  1. Pass in Destination lazily in startFlowing instead of createRequest

    @sebmarkbage
    sebmarkbage committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2476d11 View commit details
    Browse the repository at this point in the history

  2. Delay fatal errors until we have a destination to forward them to

    @sebmarkbage
    sebmarkbage committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    23bae6e View commit details
    Browse the repository at this point in the history

  3. Flow can now be inferred by whether there's a destination set 

    We can drop the destination when we're not flowing since there's nothing to
write to.

Fatal errors now close once flowing starts back up again.
    @sebmarkbage
    sebmarkbage committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e3225af View commit details
    Browse the repository at this point in the history

  4. Defer fatal errors in Flight too

    @sebmarkbage
    sebmarkbage committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2c8ffd1 View commit details
    Browse the repository at this point in the history