Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yarn build-for-devtools script to account for build/build2 changes #22418

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 24, 2021

Recent changes broke this.

@bvaughn bvaughn requested a review from acdlite September 24, 2021 14:54
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Sep 24, 2021
@bvaughn bvaughn merged commit a01cdbf into facebook:main Sep 24, 2021
@bvaughn bvaughn deleted the fix-build-for-devtools-command branch September 24, 2021 14:54
@sizebot
Copy link

sizebot commented Sep 24, 2021

Comparing: 1c58cfa...3b7e837

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.54 kB 129.54 kB = 41.29 kB 41.29 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.37 kB 132.37 kB = 42.23 kB 42.23 kB
facebook-www/ReactDOM-prod.classic.js = 411.19 kB 411.19 kB = 76.09 kB 76.09 kB
facebook-www/ReactDOM-prod.modern.js = 399.75 kB 399.75 kB = 74.38 kB 74.38 kB
facebook-www/ReactDOMForked-prod.classic.js = 411.19 kB 411.19 kB = 76.09 kB 76.09 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3b7e837

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants