Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial should recommend npm install flux #2221

Closed
wants to merge 1 commit into from

Conversation

pconerly
Copy link

react-dispatcher is deprecated, flux is the current package. Thanks!

react-dispatcher is deprecated, flux is the current package.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@brigand
Copy link
Contributor

brigand commented Sep 20, 2014

The text surrounding it doesn't make sense with this change. Also require('Flux') isn't the same as require('flux') on linux.

@@ -57,7 +57,7 @@ The dispatcher's source code is written in [ECMAScript 6](https://github.com/luk
You can get up and running with the dispatcher in a variety of ways, but perhaps the simplest is to use [Michael Jackson](https://twitter.com/mjackson)'s npm module version of the Flux project, called [react-dispatcher](https://www.npmjs.org/package/react-dispatcher):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update this link too (https://www.npmjs.org/package/react-dispatcher to /package/flux)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Sep 25, 2014

We'll be moving forward with #2236 so this won't be needed anymore. Thanks for taking the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants