Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show a soft error when a text string or number is supplied as a child to non text wrappers" #22108

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

sota000
Copy link
Contributor

@sota000 sota000 commented Aug 17, 2021

I am going to make this change only for Fabric.

Reverts #21953

… a child to non text wrappers (#21953)"

This reverts commit e9b2028.
@sizebot
Copy link

sizebot commented Aug 17, 2021

Comparing: aebf3b4...4c1da32

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.58 kB 127.58 kB = 40.72 kB 40.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.40 kB 130.40 kB = 41.65 kB 41.65 kB
facebook-www/ReactDOM-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB
facebook-www/ReactDOM-prod.modern.js = 393.72 kB 393.72 kB = 73.32 kB 73.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.16 kB 405.16 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4c1da32

@sota000 sota000 merged commit 424fe58 into main Aug 17, 2021
@rickhanlonii rickhanlonii deleted the revert-21953-invalid_text branch August 17, 2021 01:01
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Aug 17, 2021
Summary:
This sync includes the following changes:
- **[424fe5870](facebook/react@424fe5870 )**: Revert "Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953))" ([#22108](facebook/react#22108)) //<Sota>//
- **[aebf3b456](facebook/react@aebf3b456 )**: [Scheduler] Check for continuous input events ([#22107](facebook/react#22107)) //<Andrew Clark>//
- **[e9b2028b3](facebook/react@e9b2028b3 )**: Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953)) //<Sota>//
- **[ecd73e17b](facebook/react@ecd73e17b )**: Enable enableSuspenseLayoutEffectSemantics flag statically for Facebook ([#22050](facebook/react#22050)) //<Brian Vaughn>//
- **[a8725a3e6](facebook/react@a8725a3e6 )**: Scheduling profiler: Added lane labels and durations to React measures ([#22029](facebook/react#22029)) //<Brian Vaughn>//

Changelog:
[General][Changed] - React Native sync for revisions 19092ac...5634ed1

jest_e2e[run_all_tests]

Reviewed By: kacieb

Differential Revision: D30225923

fbshipit-source-id: 562895d3e0d264f40770dadb89d4a16241967c4c
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants