Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21972: Add onResize event to video elements #21973

Merged
merged 2 commits into from
Sep 7, 2021

Commits on Jul 27, 2021

  1. Fix facebook#21972: Add onResize event to video elements

    This is a simple fix for facebook#21972 that adds support for the `onResize` media event.
    
    I created a separate `videoEventTypes` array since I doubt anyone will want to add `onResize` to an audio event. It would simplify the code a bit to just add `resize` to the `mediaEventTypes` array, if that’s preferred.
    
    Pre-commit checklist ([source](https://reactjs.org/docs/how-to-contribute.html#sending-a-pull-request))
    
    ✅ Fork the repository and create your branch from `main`.
    ✅ Run `yarn` in the repository root.
    ✅ If you’ve fixed a bug or added code that should be tested, add tests!
    ✅ Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
    ✅ Run `yarn test --prod` to test in the production environment.
    ✅ If you need a debugger, run `yarn debug-test --watch TestName`, open chrome://inspect, and press “Inspect”.
    ✅ Format your code with prettier (`yarn prettier`).
    ✅ Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
    ✅ Run the Flow typechecks (`yarn flow`).
    ✅ If you haven’t already, complete the CLA.
    rileyjshaw committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    5ec46b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Configuration menu
    Copy the full SHA
    3c336f0 View commit details
    Browse the repository at this point in the history