Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge-case Fast Refresh bug that caused Fibers with warnings/errors to be untracked prematurely #21536

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix edge-case Fast Refresh bug that caused Fibers with warnings/errors to be untracked prematurely #21536

merged 2 commits into from
May 20, 2021

Commits on May 20, 2021

  1. DevTools: Fix another Fast Refresh edge case 

    Don't untrack unmounted Fibers after logging errors/warnings because it sometimes causes prematurely untracking a force-remounted Fiber from Fast Refresh, which in turn causes DevTools to break when the component is later inspected.

This is a hack but I'm not sure of a better workaround.
    Brian Vaughn committed May 20, 2021
    Configuration menu
    Copy the full SHA
    794ed49 View commit details
    Browse the repository at this point in the history

  2. Refactored DevTools pending error and warning mapping 

    This way we avoid pre-allocating Fiber IDs for not-yet-mounted Fibers.
    Brian Vaughn committed May 20, 2021
    Configuration menu
    Copy the full SHA
    9abfcaa View commit details
    Browse the repository at this point in the history