Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Reload all roots after Fast Refresh force remount #21516

Merged
merged 3 commits into from
May 18, 2021
Merged

DevTools: Reload all roots after Fast Refresh force remount #21516

merged 3 commits into from
May 18, 2021

Commits on May 18, 2021

  1. DevTools: Fix Fiber leak caused by Refresh hot reloading

    Brian Vaughn committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5dd3c57 View commit details
    Browse the repository at this point in the history

  2. DevTools resets Store after Fast Refresh force unmount 

    Fast Refresh sometimes force remounts a component in a way that DevTools can't handle. It could throw but that's a bad user experience. Or it could ignore the unmount but then Store might end up with a duplicate node. So instead, a fallback is to completely reset the Store. This is costly but since Fast Refresh is only used in DEV builds, it should be okay.
    Brian Vaughn committed May 18, 2021
    Configuration menu
    Copy the full SHA
    723f44a View commit details
    Browse the repository at this point in the history

  3. Updated comments

    Brian Vaughn committed May 18, 2021
    Configuration menu
    Copy the full SHA
    4b4ee74 View commit details
    Browse the repository at this point in the history