DevTools: Fix Fiber leak caused by Refresh hot reloading #21506
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21469 as well as #21436 and #21442 (I think)
Posting for discussion purposes with @gaearon
The general idea is to add a new hook that Fast Refresh can use to inform DevTools when a force remount is scheduled. Then DevTools can clean up any Fibers that would have otherwise been linked by the clone-and-splice operation on the tree.
Added some basic integration tests for Fast Refresh + DevTools, including one that fails without this fix: