Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped DevTools Chrome and Firefox versions in Babel config #21185

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Bumped DevTools Chrome and Firefox versions in Babel config #21185

merged 1 commit into from
Apr 6, 2021

Commits on Apr 6, 2021

  1. BUmped DevTools Chrome and Firefox versions in Babel config 

    We have been building DevTools to target Chrome 49 and Firefox 54. These are super old browser versions and they did not have full ES6 support, so the generated build is more bloated than it needs to be.

DevTools uses most modern language features. Off the top of my head, we it uses basically everything but async and generator functions.

Based on CanIUse charts– I believe that in order to avoid unnecessary polyfill/wrapper code being generated, we'd need to target Chrome 60+ (released 2017-07-25) and Firefox 55+ (released 2017-04-18). This seems like a reasonable set of browsers to target.

Note that we can't remove the IE 11 target from the react-devtools-core backend yet due to Hermes (React Native) ES6 support but that should be doable by the end of the year given current engineering targets. But we could update the frontend target, as well as the targets for the extensions and the react-devtools-inline package.

This commit increases the browser targets then for Chrome (from 49 to 60) and Firefox (from 54 to 55)
    Brian Vaughn committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4dfb43b View commit details
    Browse the repository at this point in the history