-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DevTools dependency on Scheduler runWithPriority #20967
Remove DevTools dependency on Scheduler runWithPriority #20967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
Comparing: 73e900b...168ed43 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Yup! If you think about it just ping me once you land your other PR |
@bvaughn the other PR has landed, but CI looks stuck 🤔 |
Thanks for the ping! |
dispatch(action); | ||
startTransition(() => { | ||
dispatch({type: 'UPDATE_INSPECTED_ELEMENT_ID'}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This is really much nicer. :)
Do not land before PR #20955
Should not have any observable user impact.