Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Restore inspect-element bridge optimizations #20789

Merged
merged 3 commits into from
Feb 22, 2021
Merged

DevTools: Restore inspect-element bridge optimizations #20789

merged 3 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. Restore inspect-element bridge optimizations 

    When the new Suspense cache was integrated (so that startTransition could be used) I removed a couple of optimizations between the backend and frontend that reduced bridge traffic when e.g. dehydrated paths were inspected for elements that had not rendered since previously inspected. This commit re-adds those optimizations as well as an additional test with a bug fix that I noticed while reading the backend code.

There are two remaining TODO items as of this commit:
- Make inspected element edits and deletes also use transition API
- Don't over-eagerly refresh the cache in our ping-for-updates handler

I will addres both in subsequent commits.
    Brian Vaughn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    7f4ea1e View commit details
    Browse the repository at this point in the history

  2. Poll for update only refreshes cache when there's an update

    Brian Vaughn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    73db175 View commit details
    Browse the repository at this point in the history

  3. Added inline comment

    Brian Vaughn committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    86ed0cd View commit details
    Browse the repository at this point in the history