Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Make it easier to write tests for inspected elements #20655

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 25, 2021

Wanted to add test coverage for #20626. Went ahead and tidied up a little while I was in here.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 25, 2021
And also add a few tests for  which also cover a recent bugfix that just landed
@bvaughn bvaughn force-pushed the devtools-more-tests branch from ba93b1e to 734ecb0 Compare January 25, 2021 16:56
@sizebot
Copy link

sizebot commented Jan 25, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 734ecb0

@sizebot
Copy link

sizebot commented Jan 25, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 734ecb0

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bvaughn bvaughn changed the title DevTools: Make it easier to write inspected element tests DevTools: Make it easier to write tests for inspected elements Jan 25, 2021
@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 25, 2021

This is a test-only change so I'm just going to merge it.

@bvaughn bvaughn merged commit 6d94017 into facebook:master Jan 25, 2021
@bvaughn bvaughn deleted the devtools-more-tests branch January 25, 2021 19:58
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
…ook#20655)

And also add a few tests for  which also cover a recent bugfix that just landed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants