Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESM module loaders in Flight fixture #20229

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

sebmarkbage
Copy link
Collaborator

This lets the Flight fixture run as "type": "module" or "commonjs". It now defaults to "module".

Experimental loaders can be used similar to require.extensions to do the transpilation and replacement of .client.js references.

@sebmarkbage sebmarkbage requested a review from gaearon November 12, 2020 05:14
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 12, 2020
This lets the Flight fixture run as "type": "module" or "commonjs".

Experimental loaders can be used similar to require.extensions to do the
transpilation and replacement of .client.js references.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1c197e:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Nov 12, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against d1c197e

@sizebot
Copy link

sizebot commented Nov 12, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against d1c197e

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such future

@sebmarkbage sebmarkbage merged commit e41fd1f into facebook:master Nov 12, 2020
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
This lets the Flight fixture run as "type": "module" or "commonjs".

Experimental loaders can be used similar to require.extensions to do the
transpilation and replacement of .client.js references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants