-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions for 17 #20062
Bump versions for 17 #20062
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a385e4:
|
"version": "4.1.2", | ||
"version": "4.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the point of this eslint-plugin-react-hooks
minor version bump, it appears there are no changes? Also, this new version was published without a changelog entry:
https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason other than our release script releases all packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a script is undesirable. Millions of developers are needlessly updating a "outdated" dependency, looking around for a changelog entry (that doesn't exist) to explain the new semver minor features (that also don't exist).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the changelog entry. Your opinion is noted. This was a stressful release that took us many months, and I overlooked this detail. I'm sorry to hear you were frustrated by it.
Just re-doing the same our script did on build + bumps a few more that are private but stale.
I changed
peerDeps
for React and ReactDOM to use an exact version of React. Kept it a caret in other places.