Merge adjacent ReactTextComponents in flattenChildren #1989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1988 (so click on the last commit below to view actual changes).
This PR is a super simple isolated implementation for merging adjacent ReactTextComponents just before rendering. So this does not affect
this.props.children
orcloneWithProps
. It's currently not re-entrant, it is really easy to fix simply by storing it in a magic key insidetraverseContext
instead, but that doesn't seem worth it.With this and something like #1570 we should be able to get rid of all excess markup.
Massively increased test-coverage forReactMultiChildText
.