Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Warn about undefined return value for memo and forwardRef" #19574

Closed
wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 10, 2020

Reverts #19550

Let's not have this yet.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 10, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18fde8e:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Aug 10, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 18fde8e

@sizebot
Copy link

sizebot commented Aug 10, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 18fde8e

@tjallingt
Copy link
Contributor

I'm curious why, seems strange to error for "regular" components but not for forwardRef etc

@bvaughn
Copy link
Contributor

bvaughn commented Aug 10, 2020

@tjallingt This PR (and #19575) were opened for consideration as we decide whether to keep the change from #19550 as part of our upcoming release (as it is technical a "breaking" change– although you could also argue it's a bug fix).

I think we'll end up leaving #19550 as-is and closing this PR (and #19575) but we're still discussing it.

@gaearon gaearon closed this Aug 10, 2020
@kassens kassens deleted the revert-19550-issues/19548 branch November 29, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants