Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically enable enableFilterEmptyStringAttributesDOM #19502

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Statically enable enableFilterEmptyStringAttributesDOM #19502

merged 1 commit into from
Jul 31, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 31, 2020

This enables #18513 for 17. I wasn't sure if we're including it but it seems simple enough that it's not worth delaying?

@gaearon gaearon requested review from bvaughn and sebmarkbage July 31, 2020 13:37
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 31, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e050aae:

Sandbox Source
React Configuration

bvaughn
bvaughn approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe to me. Seb?

@sizebot
Copy link

sizebot commented Jul 31, 2020

Details of bundled changes.

Comparing: 22d16cc...e050aae

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 916.65 KB 917.26 KB 208.54 KB 208.65 KB NODE_DEV
ReactDOMForked-prod.js -0.0% -0.1% 399.01 KB 398.84 KB 74 KB 73.96 KB FB_WWW_PROD
react-dom-server.node.development.js +0.4% +0.4% 138.87 KB 139.49 KB 36.72 KB 36.85 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 124.16 KB 124.2 KB 39.8 KB 39.82 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% -0.1% 414.51 KB 414.34 KB 76.75 KB 76.7 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.4% +0.4% 145.06 KB 145.7 KB 36.91 KB 37.05 KB UMD_DEV
react-dom-server.node.production.min.js 🔺+0.2% 🔺+0.1% 20.72 KB 20.76 KB 7.68 KB 7.69 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.86 KB 12.86 KB 5.04 KB 5.04 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 951.89 KB 952.67 KB 213.58 KB 213.74 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 60.89 KB 60.89 KB 17.66 KB 17.66 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 402.52 KB 402.59 KB 75.81 KB 75.82 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.71 KB 12.71 KB 4.97 KB 4.97 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.17 KB 1.17 KB 666 B 665 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 705 B 704 B UMD_PROD
ReactTestUtils-dev.js -0.2% -0.1% 55.29 KB 55.19 KB 15.5 KB 15.48 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
react-dom.development.js +0.1% +0.1% 962.99 KB 963.63 KB 211.16 KB 211.29 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 616 B 615 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 124.03 KB 124.08 KB 40.55 KB 40.56 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 129.22 KB 129.26 KB 42.19 KB 42.19 KB UMD_PROFILING
ReactDOMForked-dev.js -0.0% -0.0% 994.56 KB 994.36 KB 221.31 KB 221.26 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 129.55 KB 129.59 KB 41.45 KB 41.46 KB NODE_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.1% 20.38 KB 20.42 KB 7.54 KB 7.55 KB UMD_PROD
ReactDOM-dev.js -0.0% -0.0% 986.74 KB 986.55 KB 220.34 KB 220.29 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.1% 395.14 KB 394.97 KB 73.39 KB 73.35 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.4% +0.4% 137.6 KB 138.22 KB 36.47 KB 36.6 KB NODE_DEV
ReactDOM-profiling.js -0.0% -0.1% 409.54 KB 409.37 KB 76.02 KB 75.98 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.2% 20.3 KB 20.34 KB 7.52 KB 7.53 KB NODE_PROD
ReactDOMServer-dev.js -0.1% -0.1% 143.44 KB 143.24 KB 36.48 KB 36.44 KB FB_WWW_DEV
ReactDOMServer-prod.js -0.3% -0.2% 46.68 KB 46.53 KB 10.92 KB 10.9 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 65.91 KB 65.91 KB 18.18 KB 18.18 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against e050aae

@sizebot
Copy link

sizebot commented Jul 31, 2020

Details of bundled changes.

Comparing: 22d16cc...e050aae

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 879.54 KB 880.15 KB 201.78 KB 201.9 KB NODE_DEV
ReactDOMForked-prod.js -0.0% -0.0% 410.15 KB 409.98 KB 75.67 KB 75.64 KB FB_WWW_PROD
react-dom-server.node.development.js +0.4% +0.4% 137.36 KB 137.97 KB 36.5 KB 36.64 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.37 KB 119.41 KB 38.38 KB 38.39 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% -0.0% 425.71 KB 425.54 KB 78.39 KB 78.36 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.4% +0.4% 143.48 KB 144.11 KB 36.71 KB 36.85 KB UMD_DEV
react-dom-server.node.production.min.js 🔺+0.2% 🔺+0.2% 20.26 KB 20.3 KB 7.6 KB 7.61 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.84 KB 12.84 KB 5.03 KB 5.03 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 980.05 KB 980.83 KB 218.99 KB 219.15 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 60.88 KB 60.88 KB 17.65 KB 17.65 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 414.77 KB 414.84 KB 77.65 KB 77.66 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.7 KB 12.7 KB 4.96 KB 4.96 KB NODE_PROD
ReactTestUtils-dev.js -0.2% -0.2% 55.29 KB 55.19 KB 15.49 KB 15.47 KB FB_WWW_DEV
react-dom.development.js +0.1% +0.1% 924.08 KB 924.72 KB 204.29 KB 204.41 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.31 KB 119.35 KB 39.08 KB 39.08 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 123.21 KB 123.25 KB 40.28 KB 40.28 KB UMD_PROFILING
ReactDOMForked-dev.js -0.0% -0.0% 1020.1 KB 1019.9 KB 226.04 KB 226 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 123.44 KB 123.48 KB 39.63 KB 39.64 KB NODE_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.1% 19.92 KB 19.96 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.0% -0.0% 1012.29 KB 1012.09 KB 225.03 KB 225 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.0% 406.27 KB 406.1 KB 75.03 KB 75.01 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.5% +0.4% 136.09 KB 136.7 KB 36.26 KB 36.39 KB NODE_DEV
ReactDOM-profiling.js -0.0% -0.0% 420.73 KB 420.56 KB 77.66 KB 77.63 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.2% 19.84 KB 19.88 KB 7.44 KB 7.46 KB NODE_PROD
ReactDOMServer-dev.js -0.1% -0.1% 147.47 KB 147.27 KB 37.48 KB 37.44 KB FB_WWW_DEV
ReactDOMServer-prod.js -0.3% -0.3% 47.54 KB 47.4 KB 11.14 KB 11.11 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 65.9 KB 65.9 KB 18.18 KB 18.17 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against e050aae

@gaearon gaearon merged commit 815ee89 into facebook:master Jul 31, 2020
gaearon added a commit that referenced this pull request Jul 31, 2020
@gaearon
Revert "Statically enable enableFilterEmptyStringAttributesDOM (#19502)"
e061825 
This reverts commit 815ee89.
@gaearon gaearon mentioned this pull request Jul 31, 2020
Merged
gaearon added a commit that referenced this pull request Jul 31, 2020
@gaearon
Revert "Statically enable enableFilterEmptyStringAttributesDOM (#19502)…
332ecef 
…" (#19504)

This reverts commit 815ee89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @bvaughn @facebook-github-bot