Track event times per lane on the root #19387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6a2703c:
|
Details of bundled changes.Comparing: faa697f...6a2703c react-dom
react-art
react-native-renderer
react-reconciler
react-test-renderer
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Details of bundled changes.Comparing: faa697f...6a2703c react-dom
react-art
react-reconciler
react-test-renderer
react-native-renderer
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
|
Old fork tests are failing because I forgot to sync changes to ReactFiberRoot.old. Will fix in a bit. |
acdlite
force-pushed
the
track-event-time-on-root
branch
2 times, most recently
from
a478883
to
1327c6b
Compare
acdlite
commented
Jul 17, 2020
| let lanes = noLongerPendingLanes; | ||
| while (lanes > 0) { | ||
| const index = pickArbitraryLaneIndex(lanes); | ||
| const lane = 1 << index; | ||
|
|
||
| // Clear the expiration time | ||
| entanglements[index] = NoLanes; |
There was a problem hiding this comment.
This line was an oversight from when I added the entanglement feature. It's theoretically observable but if I write a test it'll be super convoluted, since we currently only use entanglement for useMutableSource, and only in a particular de-opt case.
bvaughn
approved these changes
Jul 17, 2020
acdlite
force-pushed
the
track-event-time-on-root
branch
from
1327c6b
to
4b3c097
Compare
Some minor rearranging so that eventTime gets threaded through. No change in behavior.
Previous strategy was to store the event time on the update object and accumulate the most recent one during the render phase. Among other advantages, by tracking them on the root, we can read the event time before the render phase has finished. I haven't removed the `eventTime` field from the update object yet, because it's still used to compute the timeout. Tracking the timeout on the root is my next step.
acdlite
force-pushed
the
track-event-time-on-root
branch
from
4b3c097
to
6a2703c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous strategy was to store the event time on the update object and accumulate the most recent one during the render phase.
Among other advantages, by tracking them on the root, we can read the event time before the render phase has finished.
I haven't removed the
eventTimefield from the update object yet, because it's still used to compute the timeout. Tracking the timeout on the root is my next step.