-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Re-enabled DebugTracing feature for old reconciler fork (#191… #19159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…book#19142)" This reverts commit cc7c1ae.
facebook-github-bot
added
React Core Team
Opened by a member of the React Core Team
CLA Signed
labels
Jun 19, 2020
acdlite
approved these changes
Jun 19, 2020
Details of bundled changes.Comparing: 090c6ed...0b1a540 react-art
react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: 090c6ed...0b1a540 react-art
react-dom
Size changes (stable) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b1a540:
|
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Jun 22, 2020
…book#19142)" (facebook#19159) This reverts commit cc7c1ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cc7c1ae.
This PR introduced a bug here.
root.finishedLanes
is potentially different before and after we callflushPassiveEffects
. This PR movedvar lanes = root.finishedLanes
before theflushPassiveEffects
call, which caused a bug in FBR. Once I can reproduce the bug in FBR I will add a unit test and fix forward.