Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Re-enabled DebugTracing feature for old reconciler fork (#191… #19159

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

lunaruan
Copy link
Contributor

@lunaruan lunaruan commented Jun 19, 2020

This reverts commit cc7c1ae.

This PR introduced a bug here. root.finishedLanes is potentially different before and after we call flushPassiveEffects. This PR moved var lanes = root.finishedLanes before the flushPassiveEffects call, which caused a bug in FBR. Once I can reproduce the bug in FBR I will add a unit test and fix forward.

@lunaruan lunaruan requested review from bvaughn and acdlite June 19, 2020 00:55
@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Jun 19, 2020
@sizebot
Copy link

sizebot commented Jun 19, 2020

Details of bundled changes.

Comparing: 090c6ed...0b1a540

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 240.22 KB 240.22 KB 42.45 KB 42.46 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 685.67 KB 685.9 KB 145.15 KB 145.19 KB UMD_DEV
react-art.development.js 0.0% 0.0% 587.29 KB 587.52 KB 127.35 KB 127.39 KB NODE_DEV
ReactART-dev.js -1.0% -0.9% 616.23 KB 610.26 KB 131.15 KB 130 KB FB_WWW_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 922.92 KB 923.16 KB 209.77 KB 209.82 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 126.77 KB 126.77 KB 40.33 KB 40.33 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 406.15 KB 406.15 KB 75.16 KB 75.17 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 144.38 KB 144.38 KB 36.79 KB 36.78 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 952.82 KB 953.06 KB 214.13 KB 214.18 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 70.09 KB 70.09 KB 19.6 KB 19.6 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 394.87 KB 394.87 KB 74.51 KB 74.51 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.61 KB 5.61 KB 1.86 KB 1.87 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 667 B 666 B NODE_PROD
react-dom.development.js 0.0% 0.0% 969.8 KB 970.03 KB 212.54 KB 212.58 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 616 B 615 B NODE_PROD
react-dom.production.min.js 0.0% -0.0% 126.55 KB 126.55 KB 41.2 KB 41.2 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 130.51 KB 130.51 KB 42.38 KB 42.38 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% -0.0% 972.47 KB 972.47 KB 217.11 KB 217.11 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 130.9 KB 130.9 KB 41.51 KB 41.51 KB NODE_PROFILING
ReactDOM-dev.js -0.6% -0.5% 979.58 KB 973.62 KB 218.4 KB 217.22 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 395.81 KB 395.81 KB 73.42 KB 73.42 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 136.98 KB 136.98 KB 36.33 KB 36.33 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 406.34 KB 406.34 KB 75.18 KB 75.18 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.51 KB 7.51 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 75.26 KB 75.26 KB 20.1 KB 20.1 KB UMD_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 0b1a540

@sizebot
Copy link

sizebot commented Jun 19, 2020

Details of bundled changes.

Comparing: 090c6ed...0b1a540

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 247.36 KB 247.36 KB 43.73 KB 43.74 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 663.51 KB 663.74 KB 141.07 KB 141.11 KB UMD_DEV
react-art.development.js 0.0% 0.0% 566.04 KB 566.27 KB 123.3 KB 123.35 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 74.42 KB 74.42 KB 23.02 KB 23.03 KB NODE_PROD
ReactART-dev.js -1.0% -0.9% 626.24 KB 620.28 KB 133.19 KB 132.03 KB FB_WWW_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 892.49 KB 892.73 KB 204.21 KB 204.25 KB NODE_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 978.62 KB 978.85 KB 219.78 KB 219.83 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 406.84 KB 406.84 KB 76.47 KB 76.47 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 938.01 KB 938.25 KB 206.86 KB 206.9 KB UMD_DEV
ReactDOMForked-dev.js 0.0% 0.0% 998.02 KB 998.02 KB 222.93 KB 222.93 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.38 KB 126.38 KB 40.25 KB 40.25 KB NODE_PROFILING
ReactDOM-dev.js -0.6% -0.5% 1005.13 KB 999.16 KB 224.2 KB 223.04 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 406.99 KB 406.99 KB 75.25 KB 75.25 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 135.46 KB 135.46 KB 36.13 KB 36.13 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 417.59 KB 417.59 KB 77.03 KB 77.03 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% 0.0% 146.54 KB 146.54 KB 37.26 KB 37.26 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.44 KB 47.44 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 75.25 KB 75.25 KB 20.1 KB 20.09 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 0b1a540

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b1a540:

Sandbox Source
thirsty-morse-86rm4 Configuration

@lunaruan lunaruan merged commit d1d9054 into facebook:master Jun 19, 2020
trueadm pushed a commit to trueadm/react that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants