Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple update priority tracking from Scheduler package #19121

Merged
merged 36 commits into from
Jul 6, 2020
Merged

Decouple update priority tracking from Scheduler package #19121

merged 36 commits into from
Jul 6, 2020

Commits on Jul 6, 2020

  1. Initial currentLanePriority implementation

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    dc66f1b View commit details
    Browse the repository at this point in the history

  2. Minor updates from review

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    dd82bcd View commit details
    Browse the repository at this point in the history

  3. Fix typos and enable flag

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4404ed2 View commit details
    Browse the repository at this point in the history

  4. Fix feature flags and lint

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a029969 View commit details
    Browse the repository at this point in the history

  5. Fix simple event tests by switching to withSuspenseConfig

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    815c4ed View commit details
    Browse the repository at this point in the history

  6. Don't lower the priority of setPending in startTransition below Input… 

    …Continuous
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    c454bda View commit details
    Browse the repository at this point in the history

  7. Move currentUpdateLanePriority in commit root into the first effect b… 

    …lock
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6fe9d23 View commit details
    Browse the repository at this point in the history

  8. Refactor requestUpdateLane to log for priority mismatches 

    Also verifies that the update lane priority matches the scheduler lane priority before using it
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    7d5c251 View commit details
    Browse the repository at this point in the history

  9. Fix four tests by adding ReactDOM.unstable_runWithPriority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    79fdca3 View commit details
    Browse the repository at this point in the history

  10. Fix partial hydration when using update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a238e2f View commit details
    Browse the repository at this point in the history

  11. Fix partial hydration when using update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    2dcd2aa View commit details
    Browse the repository at this point in the history

  12. Rename feature flag and only log for now

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    db5f479 View commit details
    Browse the repository at this point in the history

  13. Move unstable_runWithPriority to ReactFiberReconciler

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    fbbddcf View commit details
    Browse the repository at this point in the history

  14. Add unstable_runWithPriority to ReactNoopPersistent too

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    93eca31 View commit details
    Browse the repository at this point in the history

  15. Bug fixes and performance improvements

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    ce0c4a6 View commit details
    Browse the repository at this point in the history

  16. Remove higherLanePriority from ReactDOMEventReplaying.js

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6e7fbbe View commit details
    Browse the repository at this point in the history

  17. Change warning implementation and startTransition update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a2445c2 View commit details
    Browse the repository at this point in the history

  18. Inject reconciler functions to avoid importing src/

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    f3cb0d8 View commit details
    Browse the repository at this point in the history

  19. Initial currentLanePriority implementation

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    866c5ba View commit details
    Browse the repository at this point in the history

  20. Minor updates from review

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    d132425 View commit details
    Browse the repository at this point in the history

  21. Fix typos and enable flag

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    0844f04 View commit details
    Browse the repository at this point in the history

  22. Fix feature flags and lint

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e317e3a View commit details
    Browse the repository at this point in the history

  23. Fix simple event tests by switching to withSuspenseConfig

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9f472fb View commit details
    Browse the repository at this point in the history

  24. Don't lower the priority of setPending in startTransition below Input… 

    …Continuous
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    8f58f02 View commit details
    Browse the repository at this point in the history

  25. Move currentUpdateLanePriority in commit root into the first effect b… 

    …lock
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    1930096 View commit details
    Browse the repository at this point in the history

  26. Refactor requestUpdateLane to log for priority mismatches 

    Also verifies that the update lane priority matches the scheduler lane priority before using it
    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6b500da View commit details
    Browse the repository at this point in the history

  27. Fix four tests by adding ReactDOM.unstable_runWithPriority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    863ce17 View commit details
    Browse the repository at this point in the history

  28. Fix partial hydration when using update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    27adc13 View commit details
    Browse the repository at this point in the history

  29. Fix partial hydration when using update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    c6c760d View commit details
    Browse the repository at this point in the history

  30. Rename feature flag and only log for now

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    28a889f View commit details
    Browse the repository at this point in the history

  31. Move unstable_runWithPriority to ReactFiberReconciler

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9c71654 View commit details
    Browse the repository at this point in the history

  32. Bug fixes and performance improvements

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    5802d55 View commit details
    Browse the repository at this point in the history

  33. Remove higherLanePriority from ReactDOMEventReplaying.js

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    0d9812c View commit details
    Browse the repository at this point in the history

  34. Change warning implementation and startTransition update lane priority

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    383eb73 View commit details
    Browse the repository at this point in the history

  35. Inject reconciler functions to avoid importing src/

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    23eb05a View commit details
    Browse the repository at this point in the history

  36. Fixes from bad rebase

    @rickhanlonii
    rickhanlonii committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4294152 View commit details
    Browse the repository at this point in the history