Temporarily Remove DebugTracing from the New Reconciler #18697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Apr 22, 2020
| @@ -207,9 +202,6 @@ export function createUpdate( | |||
|
|
|||
| next: null, | |||
| }; | |||
| if (__DEV__) { | |||
| update.priority = getCurrentPriorityLevel(); | |||
There was a problem hiding this comment.
btw, are we actually using these in DevTools? I thought we added them for DevTools but I couldn't find any usage of them.
There was a problem hiding this comment.
It was added for the Suspense priority warning, which we later removed
There was a problem hiding this comment.
We don't need it in the new system because the priority can be determined from the lane "losslessly" without having to infer.
There was a problem hiding this comment.
I think the only place DevTools surfaces priority level info is in the Profiler, per commit:
react/packages/react-reconciler/src/ReactFiberDevToolsHook.old.js
Lines 85 to 102 in 571f5ad
Maybe that's what you were thinking of?
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1858929:
|
|
Assuming the tests pass. I assume they will because they are already gated on the flag. |
acdlite
approved these changes
Apr 22, 2020
gaearon
approved these changes
Apr 22, 2020
acdlite
reviewed
Apr 22, 2020
| @@ -19,7 +19,7 @@ export const disableInputAttributeSyncing = __VARIANT__; | |||
| export const enableFilterEmptyStringAttributesDOM = __VARIANT__; | |||
| export const enableModernEventSystem = __VARIANT__; | |||
| export const enableLegacyFBSupport = __VARIANT__; | |||
| export const enableDebugTracing = __VARIANT__; | |||
| export const enableDebugTracing = !__VARIANT__; | |||
There was a problem hiding this comment.
What's the purpose of this?
There was a problem hiding this comment.
Funny that means the behavior in the old reconciler wasn't being tested :D
There was a problem hiding this comment.
The new reconciler is enabled when the variant is true. This feature doesn't work so the tests don't pass. This ensures it's enabled in the other variant instead.
Details of bundled changes.Comparing: e5cc146...1858929 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Details of bundled changes.Comparing: e5cc146...1858929 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
15 tasks
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Jun 16, 2020
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
bvaughn
pushed a commit
that referenced
this pull request
Jun 16, 2020
It was temporarily removed by @sebmarkbage via PR #18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Jun 19, 2020
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Jun 19, 2020
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Jun 22, 2020
It was temporarily removed by @sebmarkbage via PR facebook#18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now.
bvaughn
pushed a commit
that referenced
this pull request
Jun 23, 2020
* Re-enabled DebugTracing feature for old reconciler fork It was temporarily removed by @sebmarkbage via PR #18697. Newly re-added tracing is simplified, since the lane(s) data type does not require the (lossy) conversion between priority and expiration time values. @sebmarkbage mentioned that he removed this because it might get in the way of his planned discrete/sync refactor. I'm not sure if that concern still applies, but just in case- I have only re-added it to the old reconciler fork for now. * Force Code Sandbox CI to re-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @bvaughn and @gaearon. 😢We can add it back.
Some of the concepts are changing. E.g. getting the current priority level isn't as obviously going to be in the same place. Priority field on update isn't useful anymore since the lanes convey more info. This code is also in all the places moving around. It'll be easier to just add this back than to try to keep them each time they move.